linux-kernel - Re: [PATCH] drivers:md: Remove no longer needed fixme comment in raid5.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4371.1418877863@turing-police.cc.vt.edu>
Date:	Wed, 17 Dec 2014 23:44:23 -0500
From:	Valdis.Kletnieks@...edu
To:	NeilBrown <neilb@...e.de>
Cc:	Nicholas Krause <xerofoify@...il.com>, linux-raid@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:md: Remove no longer needed fixme comment in raid5.c

On Thu, 18 Dec 2014 10:19:06 +1100, NeilBrown said:
> On Wed, 17 Dec 2014 10:49:33 -0500 Nicholas Krause <xerofoify@...il.com> wrote:
>
> > Removes the no longer needed fix me comment related to not needing the agrument faster for the function,
> > sync_request. Due to getting warnings when building without the agrument it seems that this fix me was
> > wrong and we must keep this agrument in order to avoid build warnings when building without it.

Examining raid1.c, which *does* use the go_faster parameter, I suspect
that the *real* meaning of the FIXME is that the code in raid5.c *should*
possibly be doing this that's done in raid1.c's sync_request():

        /*
         * If there is non-resync activity waiting for a turn,
         * and resync is going fast enough,
         * then let it though before starting on this new sync request.
         */
        if (!go_faster && conf->nr_waiting)
                msleep_interruptible(1000);

(Which is one of the few flow differences for the sync_request() code
in raid1.c versus raid5.c.  I'll however defer to actual RAID experts
on whether raid5 needs resync throttling, or if it's accomplished via
other means I'm not spotting.  Finding a FIXME outside of drivers/staging
is usually a "Here be fearsome and nasty dragons" comment....


Content of type "application/pgp-signature" skipped