linux-kernel - Re: [PATCH] scsi: arm: cumana

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141220173904.GL11285@n2100.arm.linux.org.uk>
Date:	Sat, 20 Dec 2014 17:39:04 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	Michael Schmitz <schmitzmic@...il.com>, linux-scsi@...r.kernel.org,
	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	linux-kernel@...r.kernel.org,
	Finn Thain <fthain@...egraphics.com.au>,
	Jeremiah Mahler <jmmahler@...il.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] scsi: arm: cumana_1.c:  Remove unused function

On Sat, Dec 20, 2014 at 09:35:53AM -0800, James Bottomley wrote:
> On Sat, 2014-12-20 at 16:58 +0000, Russell King - ARM Linux wrote:
> > On Sat, Dec 20, 2014 at 08:50:45AM -0800, Jeremiah Mahler wrote:
> > > On Sat, Dec 20, 2014 at 05:36:15PM +0100, Rickard Strandqvist wrote:
> > > > Remove the function cumanascsi_setup() that is not used anywhere.
> > > > 
> > > > This was partially found by using a static code analysis program called cppcheck.
> > > > 
> > > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> > >
> > > You can blame Linus for this one :-)
> > > 
> > > ~/linux-next$ git blame -L 38,40 drivers/scsi/arm/cumana_1.c 
> > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 38) void
> > > cumanascsi_setup(char *str, int *ints)
> > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 39) {
> > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 40) }
> > > ~/linux-next$
> > 
> > Great, that gets me off the hook :)
> 
> Well, no, it doesn't: 1da177e is the git tree root commit which was
> created by importing the existing bitkeeper version 2.6.12-rc2 into git.
> It means this code predates the git import.  You might be able to chase
> it through the history tree if you want, but that only goes back as far
> as bitkeeper history.

James, please see the smilie on the end of the comment, I wasn't being
serious.  Thanks.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/