linux-kernel - Re: [PATCH] staging: skein: Fixing various coding style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141222015729.GE28117@titan.lakedaemon.net>
Date:	Sun, 21 Dec 2014 20:57:29 -0500
From:	Jason Cooper <jason@...edaemon.net>
To:	mathieu.poirier@...aro.org
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: skein: Fixing various coding style problems

Mathieu,

On Sun, Dec 21, 2014 at 05:09:48PM -0700, mathieu.poirier@...aro.org wrote:
> From: Mathieu Poirier <mathieu.poirier@...aro.org>
> 
> Fixing errors related to the usage of do {} while (0) loop
> in single statement macros, trailing semicolon in macros and
> trailing whitespace.

Huh.  iirc, I added those do {} while(0)s to keep checkpatch happy.
Either it's gotten smarter, or something is off.

At any rate, the whole macro menagerie in here concerns me a bit and I'm
reluctant to change it until I have some time to refresh my memory on
what this code is doing.

It would be helpful if you could give scripts/objdiff a try on the
before and after effects of your patch.  If the object code doesn't
change, then we can be more confident that the patch is just style
changes.  Please also check when SKEIN_UNROLL_* is set/unset.

I really should put the patch series together to move this driver out of
staging.  Then maybe folks will stop running checkpatch against it :-)

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/