linux-kernel - Re: [PATCH 2/6] dgnc/dgnc_sysfs.c: checkpatch: Use of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141222020039.GA2489@kroah.com>
Date:	Sun, 21 Dec 2014 18:00:39 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Simone Weiss <simone.weiss@....de>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...cs.fau.de,
	lidza.louina@...il.com, driverdev-devel@...uxdriverproject.org,
	helene.gsaenger@...dium.fau.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] dgnc/dgnc_sysfs.c: checkpatch: Use of pr_err insted
 of printk

On Mon, Dec 22, 2014 at 02:17:30AM +0100, Simone Weiss wrote:
> 
> Signed-off-by: Simone Weiss <simone.weiss@....de>
> Signed-off-by: Helene Gsaenger <helene.gsaenger@...dium.fau.de>
> ---
>  drivers/staging/dgnc/dgnc_sysfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c
> index 2fd34ca..0fa2388 100644
> --- a/drivers/staging/dgnc/dgnc_sysfs.c
> +++ b/drivers/staging/dgnc/dgnc_sysfs.c
> @@ -91,7 +91,7 @@ void dgnc_create_driver_sysfiles(struct pci_driver *dgnc_driver)
>  	rc |= driver_create_file(driverfs, &driver_attr_maxboards);
>  	rc |= driver_create_file(driverfs, &driver_attr_pollrate);
>  	if (rc)
> -		printk(KERN_ERR "DGNC: sysfs driver_create_file failed!\n");
> +		pr_err("DGNC: sysfs driver_create_file failed!\n");

No, use dev_err(), as you have access to a struct device.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/