linux-kernel - Re: [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

Open Source and information security mailing list archives

Message-ID: <CADnq5_MY3+4BdWzUYffTnRWF3J4Z7nb6zyrGZK4RNwVU3axvuw@mail.gmail.com>
Date:	Mon, 22 Dec 2014 11:58:43 -0500
From:	Alex Deucher <alexdeucher@...il.com>
To:	Oded Gabbay <oded.gabbay@....com>
Cc:	Alexander Deucher <Alexander.Deucher@....com>,
	Dana Elifaz <Dana.Elifaz@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Maling list - DRI developers 
	<dri-devel@...ts.freedesktop.org>,
	Huang Ying <ying.huang@...el.com>, LKP ML <lkp@...org>
Subject: Re: [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay <oded.gabbay@....com> wrote:
> amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no
> point in trying to initialize amdkfd in 32-bit kernel.
>
> In addition, in case of specific configuration of 32-bit kernel, no modules and
> random kernel base, the symbol_request function doesn't work as expected - It
> doesn't return NULL if the symbol doesn't exists. That makes the kernel panic.
> Therefore, the as amdkfd doesn't compile in 32-bit kernel, the best way is just
> to return false immediately.
>
> Signed-off-by: Oded Gabbay <oded.gabbay@....com>

Reviewed-by: Alex Deucher <alexander.deucher@....com>

> ---
>  drivers/gpu/drm/radeon/radeon_kfd.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c
> index 242fd8b..cb77e5c 100644
> --- a/drivers/gpu/drm/radeon/radeon_kfd.c
> +++ b/drivers/gpu/drm/radeon/radeon_kfd.c
> @@ -101,6 +101,7 @@ static const struct kgd2kfd_calls *kgd2kfd;
>
>  bool radeon_kfd_init(void)
>  {
> +#ifdef CONFIG_X86_64
>         bool (*kgd2kfd_init_p)(unsigned, const struct kfd2kgd_calls*,
>                                 const struct kgd2kfd_calls**);
>
> @@ -117,6 +118,9 @@ bool radeon_kfd_init(void)
>         }
>
>         return true;
> +#else
> +       return false;
> +#endif
>  }
>
>  void radeon_kfd_fini(void)
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives