linux-kernel - Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141222184940.GB17192@tassilo.jf.intel.com>
Date:	Mon, 22 Dec 2014 10:49:40 -0800
From:	Andi Kleen <ak@...ux.intel.com>
To:	Alex Deucher <alexdeucher@...il.com>
Cc:	Oded Gabbay <oded.gabbay@....com>,
	Dana Elifaz <Dana.Elifaz@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Maling list - DRI developers 
	<dri-devel@...ts.freedesktop.org>,
	Alexander Deucher <Alexander.Deucher@....com>,
	LKP ML <lkp@...org>, rusty@...tcorp.co.au
Subject: Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit
 kernel

On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote:
> On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay <oded.gabbay@....com> wrote:
> > amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no
> > point in trying to initialize amdkfd in 32-bit kernel.
> >
> > In addition, in case of specific configuration of 32-bit kernel, no modules and
> > random kernel base, the symbol_request function doesn't work as expected - It
> > doesn't return NULL if the symbol doesn't exists. That makes the kernel panic.
> > Therefore, the as amdkfd doesn't compile in 32-bit kernel, the best way is just
> > to return false immediately.
> >
> > Signed-off-by: Oded Gabbay <oded.gabbay@....com>
> 
> Reviewed-by: Alex Deucher <alexander.deucher@....com>

Sorry but the patch is just bogus. X-bit only code is usually
a very bad sign for the code. This is not windows programing after all.

Even if you wanted to do a 64bit only driver -- which
you probably don't -- the standard way would be to exclude
it in Kconfig.

Please root-cause why symbol_request doesn't work on 32bit
and fix it properly.

+rusty.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/