lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 22 Dec 2014 10:49:40 -0800
From:	Andi Kleen <>
To:	Alex Deucher <>
Cc:	Oded Gabbay <>,
	Dana Elifaz <>,
	LKML <>,
	Maling list - DRI developers 
	Alexander Deucher <>,
	LKP ML <>,
Subject: Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit

On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote:
> On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay <> wrote:
> > amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no
> > point in trying to initialize amdkfd in 32-bit kernel.
> >
> > In addition, in case of specific configuration of 32-bit kernel, no modules and
> > random kernel base, the symbol_request function doesn't work as expected - It
> > doesn't return NULL if the symbol doesn't exists. That makes the kernel panic.
> > Therefore, the as amdkfd doesn't compile in 32-bit kernel, the best way is just
> > to return false immediately.
> >
> > Signed-off-by: Oded Gabbay <>
> Reviewed-by: Alex Deucher <>

Sorry but the patch is just bogus. X-bit only code is usually
a very bad sign for the code. This is not windows programing after all.

Even if you wanted to do a 64bit only driver -- which
you probably don't -- the standard way would be to exclude
it in Kconfig.

Please root-cause why symbol_request doesn't work on 32bit
and fix it properly.



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists