linux-kernel - Re: [PATCH] staging: lustre: cleanup align switch and case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141223093654.GA5208@hudson.localdomain>
Date:	Tue, 23 Dec 2014 01:36:54 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	samuel kihahu <skihahu@...il.com>
Cc:	gregkh@...uxfoundation.org, oleg.drokin@...el.com,
	andreas.dilger@...el.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: cleanup align switch and case

samuel,

This patch is corrupt and won't apply.  I suspect it is due to missing
spaces at the start of each line in the diff.

I recommend using 'git send-email'.  But if you are using a different
client have a look at Documentation/email-clients.txt for tips on how to
avoid these problems.

On Tue, Dec 23, 2014 at 10:57:46AM +0300, samuel kihahu wrote:
> From: samuel kihahu <skihahu@...il.com>
> 
> Align switch and case to be at the same indent.
> 
> Signed-off-by: samuel kihahu <skihahu@...il.com>
> ---
>  drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
>  1 file changed, 25 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
> index 6dd4309..b5f07fa 100644
> --- a/drivers/staging/lustre/lnet/selftest/module.c
> +++ b/drivers/staging/lustre/lnet/selftest/module.c
> @@ -61,31 +61,31 @@ lnet_selftest_fini(void)
> 	int	i;
> 
> 	switch (lst_init_step) {
> -		case LST_INIT_CONSOLE:
> -			lstcon_console_fini();
> -		case LST_INIT_FW:
> -			sfw_shutdown();
> -		case LST_INIT_RPC:
> -			srpc_shutdown();
> -		case LST_INIT_WI_TEST:
> -			for (i = 0;
> -			     i < cfs_cpt_number(lnet_cpt_table()); i++) {
> -				if (lst_sched_test[i] == NULL)
> -					continue;
> -				cfs_wi_sched_destroy(lst_sched_test[i]);
> -			}
> -			LIBCFS_FREE(lst_sched_test,
> -				    sizeof(lst_sched_test[0]) *
> -				    cfs_cpt_number(lnet_cpt_table()));
> -			lst_sched_test = NULL;
> -
> -		case LST_INIT_WI_SERIAL:
> -			cfs_wi_sched_destroy(lst_sched_serial);
> -			lst_sched_serial = NULL;
> -		case LST_INIT_NONE:
> -			break;
> -		default:
> -			LBUG();
> +	case LST_INIT_CONSOLE:
> +		lstcon_console_fini();
> +	case LST_INIT_FW:
> +		sfw_shutdown();
> +	case LST_INIT_RPC:
> +		srpc_shutdown();
> +	case LST_INIT_WI_TEST:
> +		for (i = 0;
> +		     i < cfs_cpt_number(lnet_cpt_table()); i++) {
> +			if (lst_sched_test[i] == NULL)
> +				continue;
> +			cfs_wi_sched_destroy(lst_sched_test[i]);
> +		}
> +		LIBCFS_FREE(lst_sched_test,
> +			    sizeof(lst_sched_test[0]) *
> +			    cfs_cpt_number(lnet_cpt_table()));
> +		lst_sched_test = NULL;
> +
> +	case LST_INIT_WI_SERIAL:
> +		cfs_wi_sched_destroy(lst_sched_serial);
> +		lst_sched_serial = NULL;
> +	case LST_INIT_NONE:
> +		break;
> +	default:
> +		LBUG();
> 	}
> 	return;
>  }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/