lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Dec 2014 10:55:06 +0000 From: Catalin Marinas <catalin.marinas@....com> To: Will Deacon <will.deacon@....com> Cc: Suzuki Poulose <Suzuki.Poulose@....com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] arm64: Fix SCTLR_EL1 initialisation On Wed, Dec 17, 2014 at 05:39:16PM +0000, Will Deacon wrote: > On Wed, Dec 17, 2014 at 03:50:21PM +0000, Suzuki K. Poulose wrote: > > From: "Suzuki K. Poulose" <suzuki.poulose@....com> > > > > We initialise the SCTLR_EL1 value by read-modify-writeback > > of the desired bits, leaving the other bits (including reserved > > bits(RESx)) untouched. However, sometimes the boot monitor could > > leave garbage values in the RESx bits which could have different > > implications. This patch makes sure that all the bits, including > > the RESx bits, are set to the proper state, except for the > > 'endianness' control bits, EE(25) & E0E(24)- which are set early > > in the el2_setup. > > > > Updated the state of the Bit[6] in the comment to RES0 in the > > comment. > > > > Signed-off-by: Suzuki K. Poulose <suzuki.poulose@....com> > > Cc: Will Deacon <will.deacon@....com> > > Cc: Catalin Marinas <catalin.marinas@....com> > > --- > > Looks good to me: > > Acked-by: Will Deacon <will.deacon@....com> > > Is this 3.19 material, or simply a cleanup/being cautious? I'll leave this for the 3.20 merging window. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists