linux-kernel - Re: [PATCH] rcu: remove "select IRQ_WORK" from config TREE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 24 Dec 2014 10:00:00 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org,
	Josh Triplett <josh@...htriplett.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Michal Hocko <mhocko@...e.cz>,
	Vladimir Davydov <vdavydov@...allels.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	蔡正龙 <zhenglong.cai@...c.com.cn>,
	Bertrand Jacquin <beber@...eeweb.net>,
	"Luis R. Rodriguez" <mcgrof@...e.com>,
	Fabian Frederick <fabf@...net.be>,
	Andy Lutomirski <luto@...capital.net>,
	Pranith Kumar <bobby.prani@...il.com>,
	Peter Foley <pefoley2@...oley.com>,
	Mel Gorman <mgorman@...e.de>,
	Clark Williams <clark.williams@...il.com>
Subject: Re: [PATCH] rcu: remove "select IRQ_WORK" from config TREE_RCU

On Wed, Dec 24, 2014 at 05:55:28PM +0800, Lai Jiangshan wrote:
> The 48a7639ce80c ("rcu: Make callers awaken grace-period kthread")
> removed the irq_work_queue(), so the TREE_RCU doesn't need
> irq work any more.
> 
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>

Good catch, queued for 3.20.  Thank you!

							Thanx, Paul

> ---
>  init/Kconfig      |    2 --
>  kernel/rcu/tree.h |    1 -
>  2 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index 9afb971..39b4313 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -470,7 +470,6 @@ choice
>  config TREE_RCU
>  	bool "Tree-based hierarchical RCU"
>  	depends on !PREEMPT && SMP
> -	select IRQ_WORK
>  	help
>  	  This option selects the RCU implementation that is
>  	  designed for very large SMP system with hundreds or
> @@ -480,7 +479,6 @@ config TREE_RCU
>  config PREEMPT_RCU
>  	bool "Preemptible tree-based hierarchical RCU"
>  	depends on PREEMPT
> -	select IRQ_WORK
>  	help
>  	  This option selects the RCU implementation that is
>  	  designed for very large SMP systems with hundreds or
> diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
> index 8e7b184..a47a13c 100644
> --- a/kernel/rcu/tree.h
> +++ b/kernel/rcu/tree.h
> @@ -27,7 +27,6 @@
>  #include <linux/threads.h>
>  #include <linux/cpumask.h>
>  #include <linux/seqlock.h>
> -#include <linux/irq_work.h>
> 
>  /*
>   * Define shape of hierarchy based on NR_CPUS, CONFIG_RCU_FANOUT, and
> -- 
> 1.7.4.4
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/