linux-kernel - Re: [PATCH 14/37] perf tools: Convert dead thread list into rbtree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cj5CqBAYDqOUy85cih+PX_T7zRgEvyjidTTkA=gCAmmDg@mail.gmail.com>
Date:	Sat, 27 Dec 2014 14:42:08 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	David Ahern <dsahern@...il.com>
Cc:	Jiri Olsa <jolsa@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	Stephane Eranian <eranian@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Andi Kleen <andi@...stfloor.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 14/37] perf tools: Convert dead thread list into rbtree

On Sat, Dec 27, 2014 at 2:14 AM, David Ahern <dsahern@...il.com> wrote:
> On 12/25/14 7:26 PM, Namhyung Kim wrote:
>>>>
>>>> diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h
>>>> index 0b6dcd70bc8b..413f28cf689b 100644
>>>> --- a/tools/perf/util/thread.h
>>>> +++ b/tools/perf/util/thread.h
>>>> @@ -11,10 +11,8 @@
>>>>   struct thread_stack;
>>>>
>>>>   struct thread {
>>>> -     union {
>>>> -             struct rb_node   rb_node;
>>>> -             struct list_head node;
>>>> -     };
>>>> +     struct rb_node          rb_node;
>>>> +     struct list_head        node;
>>>>        struct map_groups       *mg;
>>>>        pid_t                   pid_; /* Not all tools update this */
>>>>        pid_t                   tid;
>>>> @@ -22,7 +20,8 @@ struct thread {
>>>>        int                     cpu;
>>>>        char                    shortname[3];
>>>>        bool                    comm_set;
>>>> -     bool                    dead; /* if set thread has exited */
>>>> +     bool                    exited; /* if set thread has exited */
>>>> +     bool                    dead; /* thread is in dead_threads list */
>>>
>>>
>>> looks like this also changes the logic (new exited flag),
>>> not just the dead threads storage wheel
>>
>>
>> AFAICS the 'dead' flag is not used other than thread__exited().  And
>> it confused me a dead thread might not be in a dead_threads tree (or
>> list).  So I changed the name and no logical change intended.
>
>
> git show 236a3bbd5cb51

Thanks for the pointer.  I understand the need of delaying the move to
dead_threads list, but anyway it still makes me confused.  So I
renamed the flag to keep the current behavior and match the name
'dead' to the list/tree management to reduce further confusion.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/