lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 27 Dec 2014 13:34:17 -0500
From:	Trond Myklebust <trond.myklebust@...marydata.com>
To:	Koshy George <koshygp@...il.com>
Cc:	Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
	Linux Kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] NFS: nfs4_fs.h: Fix for checkpatch warnings

On Sat, Dec 27, 2014 at 6:30 AM, Koshy George <koshygp@...il.com> wrote:
> This patch fix checkpatch warning for nfs4_fs.h
>
> fs/nfs/nfs4_fs.h:134: ERROR: "foo *     bar" should be "foo *bar"
> fs/nfs/nfs4_fs.h:416: ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: Koshy George <koshygp@...il.com>
> [Being first patch, need some assistance]
> ---
>  fs/nfs/nfs4_fs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h
> index a081787..ae336c7 100644
> --- a/fs/nfs/nfs4_fs.h
> +++ b/fs/nfs/nfs4_fs.h
> @@ -131,7 +131,7 @@ enum {
>
>  struct nfs4_lock_state {
>         struct list_head        ls_locks;       /* Other lock stateids */
> -       struct nfs4_state *     ls_state;       /* Pointer to open state */
> +       struct nfs4_state       *ls_state;      /* Pointer to open state */
>  #define NFS_LOCK_INITIALIZED 0
>  #define NFS_LOCK_LOST        1
>         unsigned long           ls_flags;
> @@ -413,7 +413,7 @@ static inline void nfs4_schedule_session_recovery(struct nfs4_session *session,
>  extern struct nfs4_state_owner *nfs4_get_state_owner(struct nfs_server *, struct rpc_cred *, gfp_t);
>  extern void nfs4_put_state_owner(struct nfs4_state_owner *);
>  extern void nfs4_purge_state_owners(struct nfs_server *);
> -extern struct nfs4_state * nfs4_get_open_state(struct inode *, struct nfs4_state_owner *);
> +extern struct nfs4_state *nfs4_get_open_state(struct inode *, struct nfs4_state_owner *);
>  extern void nfs4_put_open_state(struct nfs4_state *);
>  extern void nfs4_close_state(struct nfs4_state *, fmode_t);
>  extern void nfs4_close_sync(struct nfs4_state *, fmode_t);
> --
> 1.9.1

Sorry, but I'm not applying this kind of patch.

-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@...marydata.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists