linux-kernel - Re: [PATCH] pinctrl: rockchip: Avoid losing interrupts when supporting both edges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6699676.mHhQhT5KAT@phil>
Date:	Sat, 27 Dec 2014 19:29:23 +0100
From:	Heiko Stübner <heiko@...ech.de>
To:	Doug Anderson <dianders@...omium.org>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandru Stan <amstan@...omium.org>,
	linux-rockchip@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: rockchip: Avoid losing interrupts when supporting both edges

Am Montag, 22. Dezember 2014, 10:47:29 schrieb Doug Anderson:
> I was seeing cases where I was losing interrupts when inserting and
> removing SD cards.  Sometimes the card would get "stuck" in the
> inserted state.
> 
> I believe that the problem was related to the code to handle the case
> where we needed both rising and falling edges.  This code would
> disable the interrupt as the polarity was switched.  If an interrupt
> came at the wrong time it could be lost.
> 
> We'll match what the gpio-dwapb.c driver does upstream and change the
> interrupt polarity without disabling things.
> 
> Signed-off-by: Doug Anderson <dianders@...omium.org>

Reviewed-by: Heiko Stuebner <heiko@...ech.de>
on a rk3188 board with the edge triggered power-button
Tested-by: Heiko Stuebner <heiko@...ech.de>


Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/