linux-kernel - fanotify: might_sleep() warning in fanotify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1412301422520.31609@pobox.suse.cz>
Date:	Tue, 30 Dec 2014 14:26:00 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Eric Paris <eparis@...hat.com>
cc:	linux-kernel@...r.kernel.org
Subject: fanotify: might_sleep() warning in fanotify_read()

Hi,

current Linus' tree is giving me

WARNING: CPU: 0 PID: 310 at kernel/sched/core.c:7303 __might_sleep+0x8d/0xa0()
do not call blocking ops when !TASK_RUNNING; state=1 set at [<ffffffff810904da>] prepare_to_wait+0x2a/0x90

which is because fanotify_read() is doing this:

	prepare_to_wait(&group->notification_waitq, &wait, TASK_INTERRUPTIBLE);
	mutex_lock(&group->notification_mutex);

i.e. calls mutex_lock() while it's already TASK_INTERRUPTIBLE.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/