linux-kernel - Re: [PATCH] skein: checkpatch: trailing whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141230152655.GM28117@titan.lakedaemon.net>
Date:	Tue, 30 Dec 2014 10:26:55 -0500
From:	Jason Cooper <jason@...edaemon.net>
To:	Andreas Siegling <andreas.siegling@....de>
Cc:	devel@...uxdriverproject.org, gregkh@...uxfoundation.org,
	eric.rost@...abylon.net, nks@...wful.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	linux-kernel@...cs.fau.de, trivial@...nel.org,
	Zhutao Lu <lvzhutao@...il.com>
Subject: Re: [PATCH] skein: checkpatch: trailing whitespace

Andreas,

On Tue, Dec 30, 2014 at 12:33:34AM +0100, Andreas Siegling wrote:
> This small patch will fix the trailing whitespace in
> drivers/staging/skein/skein_generic.c.
> 
> After applying the patch, there will only remain the checkpatch warning:
> 	WARNING: Single statement macros should not use a do {} while (0) loop
> in files which are in the directory drivers/staging/skein/
> 
> Signed-off-by: Andreas Siegling <andreas.siegling@....de>
> Signed-off-by: Zhutao Lu <lvzhutao@...il.com>

Why do you have have two S-o-b's?

> ---
>  drivers/staging/skein/skein_generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 85bd7d0..4eaae1d 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -191,7 +191,7 @@ static int __init skein_generic_init(void)
>  
>  	return 0;
>  
> -		
> +

Hmm, this extra line should just be deleted.

thx,

Jason.

>  unreg512:
>  	crypto_unregister_shash(&alg512);
>  unreg256:
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/