linux-kernel - Re: [PATCH v2 0/2] staging: skein: Fixing various coding style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141230152923.GN28117@titan.lakedaemon.net>
Date:	Tue, 30 Dec 2014 10:29:23 -0500
From:	Jason Cooper <jason@...edaemon.net>
To:	mathieu.poirier@...aro.org
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] staging: skein: Fixing various coding style
 problems

Mathieu,

On Mon, Dec 22, 2014 at 08:20:37AM -0700, mathieu.poirier@...aro.org wrote:
> From: Mathieu Poirier <mathieu.poirier@...aro.org>
> 
> This patchset is fixing miscellaneous coding style problems as reported
> by checkpatch.  More interesting is the removal of 'do {} while (0) loop'
> statements for single line macros.  The following provides a guarantee the
> semantic of the object code hasn't been altered by the rectification:
> 
> mpoirier@...0:~/work/kernel1$
> 146320048532 staging: skein: Fixing single statement macro checkpatch warning
> ef68ffa9fd3e staging: skein: Fixing trailing whitespace error
> 97bf6af1f928 Linux 3.19-rc1
> mpoirier@...0:~/work/kernel1$ git reset --hard 97bf6af1f928
> HEAD is now at 97bf6af1f928 Linux 3.19-rc1
> mpoirier@...0:~/work/kernel1$ make drivers/staging/skein/skein_block.o
>   CHK     include/config/kernel.release
>   UPD     include/config/kernel.release
>   CHK     include/generated/uapi/linux/version.h
>   CHK     include/generated/utsrelease.h
>   UPD     include/generated/utsrelease.h
>   CALL    scripts/checksyscalls.sh
>   CC      drivers/staging/skein/skein_block.o
> mpoirier@...0:~/work/kernel1$ ./scripts/objdiff record drivers/staging/skein/skein_block.o
> mpoirier@...0:~/work/kernel1$ git reset --hard 146320048532
> HEAD is now at 146320048532 staging: skein: Fixing single statement macro checkpatch warning
> mpoirier@...0:~/work/kernel1$ make drivers/staging/skein/skein_block.o
>   CHK     include/config/kernel.release
>   UPD     include/config/kernel.release
>   CHK     include/generated/uapi/linux/version.h
>   CHK     include/generated/utsrelease.h
>   UPD     include/generated/utsrelease.h
>   CALL    scripts/checksyscalls.sh
>   CC      drivers/staging/skein/skein_block.o
> mpoirier@...0:~/work/kernel1$ ./scripts/objdiff record drivers/staging/skein/skein_block.o
> mpoirier@...0:~/work/kernel1$ ./scripts/objdiff diff 97bf6af1f928 146320048532
> mpoirier@...0:~/work/kernel1$
> 
> New to this patchset:
> . Introduction of a cover letter that includes a scripts/objdiff snapshot
> . Splitting of the change set by semantic
> 
> Mathieu Poirier (2):
>   staging: skein: Fixing trailing whitespace error
>   staging: skein: Fixing single statement macro checkpatch warning
> 
>  drivers/staging/skein/skein_block.c   | 17 ++++-------------
>  drivers/staging/skein/skein_generic.c |  1 -
>  2 files changed, 4 insertions(+), 14 deletions(-)

Awesome!  For the whole series,

Acked-by:  Jason Cooper <jason@...edaemon.net>

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/