linux-kernel - Re: [PATCH] smack: Fix a bidirectional UDS connect check typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54A2DBEA.2060509@schaufler-ca.com>
Date:	Tue, 30 Dec 2014 09:07:54 -0800
From:	Casey Schaufler <casey@...aufler-ca.com>
To:	Zbigniew Jasinski <z.jasinski@...sung.com>
CC:	James Morris <james.l.morris@...cle.com>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH] smack: Fix a bidirectional UDS connect check typo

On 12/29/2014 6:34 AM, Zbigniew Jasinski wrote:
> The 54e70ec5eb090193b03e69d551fa6771a5a217c4 commit introduced a
> bidirectional check that should have checked for mutual WRITE access
> between two labels. Due to a typo subject's OUT label is checked with
> object's OUT. Should be OUT to IN.
>
> Signed-off-by: Zbigniew Jasinski <z.jasinski@...sung.com>

Applied to git://git.gitorious.org/smack-next/kernel.git#smack-for-3.20

> ---
>  security/smack/smack_lsm.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index b774029..30f61f8 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -3313,7 +3313,7 @@ static int smack_unix_stream_connect(struct sock *sock,
>  
>  	if (!smack_privileged(CAP_MAC_OVERRIDE)) {
>  		skp = ssp->smk_out;
> -		okp = osp->smk_out;
> +		okp = osp->smk_in;
>  #ifdef CONFIG_AUDIT
>  		smk_ad_init_net(&ad, __func__, LSM_AUDIT_DATA_NET, &net);
>  		smk_ad_setfield_u_net_sk(&ad, other);
> @@ -3321,6 +3321,8 @@ static int smack_unix_stream_connect(struct sock *sock,
>  		rc = smk_access(skp, okp, MAY_WRITE, &ad);
>  		rc = smk_bu_note("UDS connect", skp, okp, MAY_WRITE, rc);
>  		if (rc == 0) {
> +			okp = osp->smk_out;
> +			skp = ssp->smk_in;
>  			rc = smk_access(okp, skp, MAY_WRITE, NULL);
>  			rc = smk_bu_note("UDS connect", okp, skp,
>  						MAY_WRITE, rc);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/