linux-kernel - Re: [PATCH v2 2/4] staging: rtl8192u: fix whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1420060806.6066.1.camel@perches.com>
Date:	Wed, 31 Dec 2014 13:20:06 -0800
From:	Joe Perches <joe@...ches.com>
To:	Lorenzo Stoakes <lstoakes@...il.com>
Cc:	gregkh@...uxfoundation.org, anarey@...il.com,
	mcgrof@...not-panic.com, tapaswenipathak@...il.com,
	rmfrfs@...il.com, yejiayily@...il.com, gdonald@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] staging: rtl8192u: fix whitespace

On Wed, 2014-12-31 at 21:10 +0000, Lorenzo Stoakes wrote:
> This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace
> in r8192U_dm.c and additionally it removes inconsistent whitespace throughout.
[]
> diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
[]
> +static u32 edca_setting_DL[HT_IOT_PEER_MAX] = {
> +	0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0xa44f, 0x5ea44f
> +};
> +static u32 edca_setting_UL[HT_IOT_PEER_MAX] = {
> +		0x5e4322, 0xa44f, 0x5e4322, 0x604322, 0x5ea44f, 0x5ea44f
> +};

It'd be nicer to use the same form and indentation
for both entries.

Probably be nicer to use:

static u32 edca_setting_DL[HT_IOT_PEER_MAX] = {
	0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0x00a44f, 0x5ea44f
};
static u32 edca_setting_UL[HT_IOT_PEER_MAX] = {
	0x5e4322, 0x00a44f, 0x5e4322, 0x604322, 0x5ea44f, 0x5ea44f
};

so that the entries align too.

Would it be better to use const?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/