linux-kernel - Re: [PATCH v2 2/4] staging: rtl8192u: fix whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 31 Dec 2014 21:28:06 +0000
From:	Lorenzo Stoakes <lstoakes@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	gregkh@...uxfoundation.org, Ana Rey <anarey@...il.com>,
	mcgrof@...not-panic.com, tapaswenipathak@...il.com,
	Rui Silva <rmfrfs@...il.com>, Jiayi Ye <yejiayily@...il.com>,
	Greg Donald <gdonald@...il.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] staging: rtl8192u: fix whitespace

On 31 December 2014 at 21:20, Joe Perches <joe@...ches.com> wrote:

> It'd be nicer to use the same form and indentation
> for both entries.
>
> Probably be nicer to use:
>
> static u32 edca_setting_DL[HT_IOT_PEER_MAX] = {
>         0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0x00a44f, 0x5ea44f
> };
> static u32 edca_setting_UL[HT_IOT_PEER_MAX] = {
>         0x5e4322, 0x00a44f, 0x5e4322, 0x604322, 0x5ea44f, 0x5ea44f
> };
>
> so that the entries align too.

Ack... I am a bit of a beginner at the kernel, I think you can tell
;-) I didn't mean for this to have different indentation, in fixing up
other issues I missed this one, will fix. Will also add the 00 prefix,
good idea (+ update the commit message to accommodate.)

>
> Would it be better to use const?
>

I think this would be better as a separate patch as that is getting
into changing actual semantics rather than just simple style fixes,
there is a lot that could be improved here in that realm I think :)

Best, Lorenzo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/