linux-kernel - Re: [PATCH v2 3/4] staging: rtl8192u: remove redundant code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Jan 2015 10:28:49 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Lorenzo Stoakes <lstoakes@...il.com>
Cc:	gregkh@...uxfoundation.org, anarey@...il.com,
	mcgrof@...not-panic.com, tapaswenipathak@...il.com,
	joe@...ches.com, rmfrfs@...il.com, yejiayily@...il.com,
	gdonald@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] staging: rtl8192u: remove redundant code

On Thu, Jan 01, 2015 at 10:19:56AM +0530, Sudip Mukherjee wrote:
> On Wed, Dec 31, 2014 at 09:10:42PM +0000, Lorenzo Stoakes wrote:
> > This patch fixes warnings/errors raised by checkpatch.pl relating to redundant
> > code in r8192U_dm.c.
> > 
> > Signed-off-by: Lorenzo Stoakes <lstoakes@...il.com>
> > ---
> >  drivers/staging/rtl8192u/r8192U_dm.c | 176 +++++++++++++++++------------------
> >  1 file changed, 84 insertions(+), 92 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
> > index 862d2ab..ed566bb 100644
> > --- a/drivers/staging/rtl8192u/r8192U_dm.c
> > +++ b/drivers/staging/rtl8192u/r8192U_dm.c
> > @@ -410,9 +410,9 @@ static void dm_check_rate_adaptive(struct net_device *dev)
> > 
> >  			ratr_value = targetRATR;
> >  			RT_TRACE(COMP_RATE, "currentRATR = %x, targetRATR = %x\n", currentRATR, targetRATR);
> > -			if (priv->rf_type == RF_1T2R) {
> > +			if (priv->rf_type == RF_1T2R)
> >  				ratr_value &= ~(RATE_ALL_OFDM_2SS);
> > -			}
> > +
> but this is just removal of unnecessary braces. this is not removal of redundant code.
and, missed writing in the last mail.
your [PATCH v2 2/4] and [PATCH v2 3/4] are same.

thanks
sudip
> 
<snip>
> >  			write_nic_dword(dev, RATR0, ratr_value);
> >  			write_nic_byte(dev, UFWP, 1);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/