linux-kernel - Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 31 Dec 2014 21:40:13 -0800
From:	Joe Perches <joe@...ches.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Lorenzo Stoakes <lstoakes@...il.com>, gregkh@...uxfoundation.org,
	anarey@...il.com, mcgrof@...not-panic.com,
	tapaswenipathak@...il.com, rmfrfs@...il.com, yejiayily@...il.com,
	gdonald@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace

On Thu, 2015-01-01 at 10:17 +0530, Sudip Mukherjee wrote:
> On Wed, Dec 31, 2014 at 09:33:43PM +0000, Lorenzo Stoakes wrote:
> > This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace
> > in r8192U_dm.c and additionally it removes inconsistent whitespace
> > throughout.
> > 
> > Additionally some 0x00... padding has been added for alignment to the
> > edca_setting_* variables.
> 
> i may be wrong, but looks like you are doing many different things in the patch, not just whitespace errors.
> marked a few, please see inline - 

Don't get carried away with patch type separation
and please remember to trim your replies to just
the areas you comment on.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/