linux-kernel - Re: [PATCH] staging: gdm724x: fix coding style issues

Open Source and information security mailing list archives

Date:	Sun, 04 Jan 2015 08:17:51 +0100
From:	Ning Zhou <zhou.ning.gd@...il.com>
To:	Konrad Zapalowicz <bergo.torino@...il.com>
CC:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	monamagarwal123@...il.com, gulsah.1004@...il.com,
	daniel.dy.ngu@...il.com, dh.herrmann@...il.com,
	josh@...htriplett.org, linux-kernel@...r.kernel.org, teg@...m.no,
	sjw0410@...il.com, dilekuzulmez@...il.com, davem@...emloft.net
Subject: Re: [PATCH] staging: gdm724x: fix coding style issues

OK, then this one is abandoned. I will send two patches instead.

/Ning

On 2015-01-04 02:27, Konrad Zapalowicz wrote:
> On 01/03, Ning Zhou wrote:
>> Signed-off-by: Ning Zhou <zhou.ning.gd@...il.com>
> 
> You need to describe your changes, a vague subject is not enough. Also
> keep in mind that one patch shall address one category of stuff and
> seems that yours could be separated into two.
> 
> thanks,
> konrad
> 
>> ---
>>  drivers/staging/gdm724x/gdm_lte.c | 3 ++-
>>  drivers/staging/gdm724x/gdm_mux.c | 2 +-
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
>> index 73eede1..7c4a77b 100644
>> --- a/drivers/staging/gdm724x/gdm_lte.c
>> +++ b/drivers/staging/gdm724x/gdm_lte.c
>> @@ -281,7 +281,8 @@ static int gdm_lte_emulate_ndp(struct sk_buff *skb_in, u32 nic_type)
>>  		icmp6_out.icmp6_type = NDISC_NEIGHBOUR_ADVERTISEMENT;
>>  		icmp6_out.icmp6_code = 0;
>>  		icmp6_out.icmp6_cksum = 0;
>> -		icmp6_out.icmp6_dataun.un_data32[0] = htonl(0x60000000); /* R=0, S=1, O=1 */
>> +		/* R=0, S=1, O=1 */
>> +		icmp6_out.icmp6_dataun.un_data32[0] = htonl(0x60000000);
>>  
>>  		ns = (struct neighbour_solicitation *)
>>  			(skb_in->data + mac_header_len +
>> diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
>> index b5b063a..d1ab996 100644
>> --- a/drivers/staging/gdm724x/gdm_mux.c
>> +++ b/drivers/staging/gdm724x/gdm_mux.c
>> @@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)
>>  static void do_rx(struct work_struct *work)
>>  {
>>  	struct mux_dev *mux_dev =
>> -		container_of(work, struct mux_dev , work_rx.work);
>> +		container_of(work, struct mux_dev, work_rx.work);
>>  	struct mux_rx *r;
>>  	struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;
>>  	unsigned long flags;
>> -- 
>> 1.9.1
>>
>> _______________________________________________
>> devel mailing list
>> devel@...uxdriverproject.org
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives