linux-kernel - Re: [PATCH] arch: m68k: mac: misc.c: Remove some unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1501041045020.15927@nippy.intranet>
Date:	Sun, 4 Jan 2015 18:21:42 +1100 (AEDT)
From:	Finn Thain <fthain@...egraphics.com.au>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
cc:	Joshua Thompson <funaho@...ai.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch: m68k: mac: misc.c: Remove some unused functions


On Thu, 1 Jan 2015, Rickard Strandqvist wrote:

> Removes some functions that are not used anywhere:
> mac_pram_write() mac_pram_read()
> 

If you remove those functions, you'd then find that all of the called 
functions become unused:

maciisi_read_pram
maciisi_write_pram
pmu_read_pram
pmu_write_pram
cuda_read_pram
cuda_write_pram
via_read_pram
via_write_pram

I'd rather not remove all of this code. Better to finish the 
implementation.

If we provide access to the PRAM (i.e. NVRAM) from userspace then the 
EMILE bootloader would be able to assign the boot device, for example.

Within the kernel, the CUDA PRAM functions could be used by valkyriefb to 
determine the correct default video mode (see comment in that driver).

Would it be acceptable to utilize drivers/char/generic_nvram.c and 
CONFIG_GENERIC_NVRAM? This is the PowerMac PRAM driver but looks generic 
enough that it may not need any modification for 68k Macs.

-- 

> This was partially found by using a static code analysis program called 
> cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  arch/m68k/mac/misc.c |   46 ----------------------------------------------
>  1 file changed, 46 deletions(-)
> 
> diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c
> index 707b61a..6fe7eb6 100644
> --- a/arch/m68k/mac/misc.c
> +++ b/arch/m68k/mac/misc.c
> @@ -453,52 +453,6 @@ void pmu_shutdown(void)
>   *-------------------------------------------------------------------
>   */
>  
> -void mac_pram_read(int offset, __u8 *buffer, int len)
> -{
> -	__u8 (*func)(int);
> -	int i;
> -
> -	switch(macintosh_config->adb_type) {
> -	case MAC_ADB_IISI:
> -		func = maciisi_read_pram; break;
> -	case MAC_ADB_PB1:
> -	case MAC_ADB_PB2:
> -		func = pmu_read_pram; break;
> -	case MAC_ADB_CUDA:
> -		func = cuda_read_pram; break;
> -	default:
> -		func = via_read_pram;
> -	}
> -	if (!func)
> -		return;
> -	for (i = 0 ; i < len ; i++) {
> -		buffer[i] = (*func)(offset++);
> -	}
> -}
> -
> -void mac_pram_write(int offset, __u8 *buffer, int len)
> -{
> -	void (*func)(int, __u8);
> -	int i;
> -
> -	switch(macintosh_config->adb_type) {
> -	case MAC_ADB_IISI:
> -		func = maciisi_write_pram; break;
> -	case MAC_ADB_PB1:
> -	case MAC_ADB_PB2:
> -		func = pmu_write_pram; break;
> -	case MAC_ADB_CUDA:
> -		func = cuda_write_pram; break;
> -	default:
> -		func = via_write_pram;
> -	}
> -	if (!func)
> -		return;
> -	for (i = 0 ; i < len ; i++) {
> -		(*func)(offset++, buffer[i]);
> -	}
> -}
> -
>  void mac_poweroff(void)
>  {
>  	/*
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/