linux-kernel - Re: [PATCH] GMAC: fix simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150104.222022.55122203599464788.davem@davemloft.net>
Date:	Sun, 04 Jan 2015 22:20:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	fengguang.wu@...el.com, roger.chen@...k-chips.com,
	kbuild-all@...org, peppe.cavallaro@...com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] GMAC: fix simple_return.cocci warnings

From: Joe Perches <joe@...ches.com>
Date: Fri, 02 Jan 2015 16:46:45 -0800

> On Sat, 2015-01-03 at 08:25 +0800, kbuild test robot wrote:
>> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:425:1-4: WARNING: end returns can be simpified
>> 
>>  Simplify a trivial if-return sequence.  Possibly combine with a
>>  preceding function call.
>> Generated by: scripts/coccinelle/misc/simple_return.cocci
>> 
>> CC: Roger Chen <roger.chen@...k-chips.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
>> ---
>> 
>>  dwmac-rk.c |    6 +-----
>>  1 file changed, 1 insertion(+), 5 deletions(-)
>> 
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
>> @@ -422,11 +422,7 @@ static int rk_gmac_init(struct platform_
>>  	if (ret)
>>  		return ret;
>>  
>> -	ret = gmac_clk_enable(bsp_priv, true);
>> -	if (ret)
>> -		return ret;
>> -
>> -	return 0;
>> +	return gmac_clk_enable(bsp_priv, true);
> 
> I think this change is not particularly better.
> 
> When the pattern is multiply repeated like:
 ...
> I think it's better to not change the last
> test in the sequence just to minimize overall
> line count.

I think it's a wash and that both ways are about the same to me.

I won't apply this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/