lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 05 Jan 2015 14:52:06 +0100 From: Maarten Lankhorst <maarten.lankhorst@...onical.com> To: David Miller <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, James Morris <jmorris@...ei.org>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Patrick McHardy <kaber@...sh.net> CC: netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org> Subject: [RFC PATCH] unlock rtnl mutex in ic_open_devs while waiting This fixes a deadlock with alx_link_check, which takes the rtnl_mutex in a work item to check the link. I have no idea whether alx should be fixed or ipconfig.c, but this saves 120 seconds off my boot time. ;-) Signed-off-by: Maarten Lankhorst <maarten.lankhorst@...onical.com> --- diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index 7fa18bc7e47f..c8aa15a0cdf4 100644 --- a/net/ipv4/ipconfig.c +++ b/net/ipv4/ipconfig.c @@ -270,7 +270,9 @@ static int __init ic_open_devs(void) if (ic_is_init_dev(dev) && netif_carrier_ok(dev)) goto have_carrier; + rtnl_unlock(); msleep(1); + rtnl_lock(); if (time_before(jiffies, next_msg)) continue; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists