| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Jan 2015 13:52:33 +0000 From: Vineet Gupta <Vineet.Gupta1@...opsys.com> To: Peter Hurley <peter@...leysoftware.com>, Vineet Gupta <Vineet.Gupta1@...opsys.com>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org> CC: "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "robh@...nel.org" <robh@...nel.org>, "jslaby@...e.cz" <jslaby@...e.cz>, Arnd Bergmann <arnd@...db.de> Subject: Re: [PATCH v2 2/3] serial: 8250_early: prepare for dynamic BASE_BAUD On Monday 05 January 2015 07:04 PM, Peter Hurley wrote: >> Also what do u think of the early IER optimization ? > Seems ok except the commit changelog is wrong: IER is disabled twice per _line_. > How did you profile it? It's ok if the answer is "seemed faster"; I'm just > curious. Looking at the code yes this would be per line - but I vaguely remember seeing it for every char - this was when debugging a systemC model for 8250. Its been a while... I'd added prints in the model whenever IER would wiggle and it was just being written with 0's again and again when in the early polling based printing mode. I'll send a revised version with fixed changelog. Thx, -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists