lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 5 Jan 2015 17:33:06 -0400
From:	Eduardo Valentin <edubezval@...il.com>
To:	Nishanth Menon <nm@...com>
Cc:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Zhang Rui <rui.zhang@...el.com>, Tero Kristo <t-kristo@...com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-omap <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] thermal: ti-soc-thermal: ti-bandgap.c:  Remove unused
 function

On Wed, Dec 24, 2014 at 08:57:14AM -0600, Nishanth Menon wrote:
> On 12/21/2014 11:43 AM, Rickard Strandqvist wrote:
> > Remove the function ti_bandgap_write_thot() that is not used anywhere.
> > 
> > This was partially found by using a static code analysis program called cppcheck.
> > 
> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> > ---
> >  drivers/thermal/ti-soc-thermal/ti-bandgap.c |   13 -------------
> >  drivers/thermal/ti-soc-thermal/ti-bandgap.h |    1 -
> >  2 files changed, 14 deletions(-)
> > 
> > diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> > index 634b6ce..cbb6a5f 100644
> > --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> > +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> > @@ -611,19 +611,6 @@ int ti_bandgap_read_thot(struct ti_bandgap *bgp, int id, int *thot)
> >  }
> >  
> >  /**
> > - * ti_bandgap_write_thot() - sets sensor current thot
> > - * @bgp: pointer to bandgap instance
> > - * @id: sensor id
> > - * @val: desired thot value
> > - *
> > - * Return: 0 on success or the proper error code
> > - */
> > -int ti_bandgap_write_thot(struct ti_bandgap *bgp, int id, int val)
> > -{
> > -	return _ti_bandgap_write_threshold(bgp, id, val, true);
> > -}
> > -
> > -/**
> >   * ti_bandgap_read_tcold() - reads sensor current tcold
> >   * @bgp: pointer to bandgap instance
> >   * @id: sensor id
> > diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.h b/drivers/thermal/ti-soc-thermal/ti-bandgap.h
> > index b3adf72..976afc0 100644
> > --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.h
> > +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.h
> > @@ -371,7 +371,6 @@ struct ti_bandgap_data {
> >  };
> >  
> >  int ti_bandgap_read_thot(struct ti_bandgap *bgp, int id, int *thot);
> > -int ti_bandgap_write_thot(struct ti_bandgap *bgp, int id, int val);
> >  int ti_bandgap_read_tcold(struct ti_bandgap *bgp, int id, int *tcold);
> >  int ti_bandgap_write_tcold(struct ti_bandgap *bgp, int id, int val);
> >  int ti_bandgap_read_update_interval(struct ti_bandgap *bgp, int id,
> > 
> 
> Not sure if removing support for programming of hot threshold is a
> good idea. how about ti_bandgap_write_tcold then?


Agreed here. I believe the right thing to do is to use those functions
to update the thresholds when necessary.

> 
> 
> -- 
> Regards,
> Nishanth Menon

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)

Powered by blists - more mailing lists