linux-kernel - Re: [PATCH 1/8] fs/9p: Deletion of unnecessary checks before the function call "p9_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 Jan 2015 22:41:52 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	Eric Van Hensbergen <ericvh@...il.com>,
	Latchesar Ionkov <lucho@...kov.net>,
	Ron Minnich <rminnich@...dia.gov>,
	v9fs-developer@...ts.sourceforge.net,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/8] fs/9p: Deletion of unnecessary checks before the
 function call "p9_client_clunk"



On Mon, 5 Jan 2015, SF Markus Elfring wrote:

> >> The p9_client_clunk() function tests whether its argument is NULL
> >> and then returns immediately. Thus the test around the call is not needed.
> >>
> > 
> > Not true.  You are not allowed to call p9_client_clunk(NULL).
> 
> I find that it will work in principle if we refer to the same
> function implementation.
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/net/9p/client.c?id=d8282ea05ad119247122de23db7d48ad6098cfa2#n1448
> http://lxr.free-electrons.com/source/net/9p/client.c#L1448

What do you mean by "work in principle"?  One possible issue is the return 
value - I don't have the original patch so I don't know what is the call 
site, so I don't know if that is an issue.  But you don't want to do a 
dump_stack for no reason.  That would at best be very misleading, and I 
would imagine be quite expensive.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/