linux-kernel - Re: [V9fs-developer] [PATCH 1/8] fs/9p: Deletion of unnecessary checks before the function call "p9_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54ABF260.9020904@users.sourceforge.net>
Date:	Tue, 06 Jan 2015 15:34:08 +0100
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	Dominique Martinet <dominique.martinet@....fr>,
	Julia Lawall <julia.lawall@...6.fr>
CC:	Latchesar Ionkov <lucho@...kov.net>,
	Eric Van Hensbergen <ericvh@...il.com>,
	kernel-janitors@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Ron Minnich <rminnich@...dia.gov>,
	v9fs-developer@...ts.sourceforge.net,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [V9fs-developer] [PATCH 1/8] fs/9p: Deletion of unnecessary checks
 before the function call "p9_client_clunk"

>> jumping to label error from a failure in p9_client_fcreate (e.g. EPERM
>> or something perfectly valid) will, with your patch, call clunk with fid
>> == NULL and thus generate a stack trace, while it is a perfectly normal
>> code path that should only return to userspace with EPERM.
> 
> Actually just seen that this precise example is fixed along with more
> similar code paths in subsequents (!) patchs of the set.

Do you refer to my update suggestions with a subject like "One function
call less in v9fs_…" here?


> It could actually be interesting to see if we could get all such
> paths "fixed".

Would you like to see any more specific source code clean-up?
Which kind of fine-tuning have you got in mind?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/