linux-kernel - Re: [PATCH 2/2] w1: slaves: w1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Jan 2015 21:19:07 +0100
From:	Mariusz Gorski <marius.gorski@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Evgeniy Polyakov <zbr@...emap.net>, David Fries <David@...es.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] w1: slaves: w1_therm: Add temp attribute

On Tue, Jan 06, 2015 at 09:42:21AM -0800, Greg Kroah-Hartman wrote:
> On Tue, Jan 06, 2015 at 03:29:56PM +0100, Mariusz Gorski wrote:
> > Add new attribute to simplify reading of current temperature.
> > 
> > Signed-off-by: Mariusz Gorski <marius.gorski@...il.com>
> > ---
> >  drivers/w1/slaves/w1_therm.c | 32 ++++++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> 
> You add sysfs attributes without adding new Documentation/ABI/ entries,
> which means I can't take this patch series, sorry.  Please redo it and
> add the needed information.
> 
> Also, temperature should be a standard sensor attribute, so you might
> want to use that subsystem instead of creating your own ABI here.

Do you mean stuff described in Documentation/thermal/sysfs-api.txt? I am
not exactly sure which subsystem you mean.

> thanks,
> 
> greg k-h

Thanks,
Mariusz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/