lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <yq1tx0378bn.fsf@sermon.lab.mkp.net>
Date:	Tue, 06 Jan 2015 19:17:32 -0500
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Sreekanth Reddy <sreekanth.reddy@...gotech.com>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"jejb\@kernel.org" <jejb@...nel.org>,
	Christoph Hellwig <hch@...radead.org>,
	"linux-scsi\@vger.kernel.org" <linux-scsi@...r.kernel.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Sathya Prakash <Sathya.Prakash@...gotech.com>,
	Nagalakshmi Nandigama <Nagalakshmi.Nandigama@...gotech.com>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/22] [SCSI] mpt2sas, mpt3sas: Removing uppper boundary restriction for the module parameter max_sgl_entries

>>>>> "Sreekanth" == Sreekanth Reddy <sreekanth.reddy@...gotech.com> writes:

Sreekanth> I though to warn the user that the module parameter
Sreekanth> max_sgl_entries value what they provided is greater than the
Sreekanth> kernel defined SCSI_MAX_SG_SEGMENTS, whether if this module
Sreekanth> parameter value is greater than or less than the
Sreekanth> SCSI_MAX_SG_CHAIN_SEGMENTS. Also I thought, user may confuse
Sreekanth> if see observes SCSI_MAX_SG_CHAIN_SEGMENTS value instead of
Sreekanth> max_sgl_entries value in the warning message.

I would just prefer to see the value that is in effect. I know what I
provided as override value.

At the very least print a warning if you subsequently clamp the value to
MAX_SG_CHAIN_SEGMENTS. "Requested number of segments %u is bigger than
kernel max %u".

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ