linux-kernel - Re: [PATCH] mmc: mmci: Get rid of unused variable and operations on it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54AE4A3A.1050806@smartplayin.com>
Date:	Thu, 08 Jan 2015 14:43:30 +0530
From:	Pramod Gurav <pramod.gurav@...rtplayin.com>
To:	ulf.hansson@...aro.org
CC:	linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
	linux@....linux.org.uk, chris@...ntf.net
Subject: Re: [PATCH] mmc: mmci: Get rid of unused variable and operations
 on it

Hi Ulf,

Any comment on this change?

Thanks
Pramod
On Tuesday 16 December 2014 07:21 PM, Pramod Gurav wrote:
> DMA configuration has been removed from function mmci_dma_setup but the
> local mask variable was not removed. This remains unused hence remove
> it from the function and operations on it
> 
> Signed-off-by: Pramod Gurav <pramod.gurav@...rtplayin.com>
> ---
>  drivers/mmc/host/mmci.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> index f31d702..08bbeb0 100644
> --- a/drivers/mmc/host/mmci.c
> +++ b/drivers/mmc/host/mmci.c
> @@ -435,7 +435,6 @@ static void mmci_init_sg(struct mmci_host *host, struct mmc_data *data)
>  static void mmci_dma_setup(struct mmci_host *host)
>  {
>  	const char *rxname, *txname;
> -	dma_cap_mask_t mask;
>  	struct variant_data *variant = host->variant;
>  
>  	host->dma_rx_channel = dma_request_slave_channel(mmc_dev(host->mmc), "rx");
> @@ -444,10 +443,6 @@ static void mmci_dma_setup(struct mmci_host *host)
>  	/* initialize pre request cookie */
>  	host->next_data.cookie = 1;
>  
> -	/* Try to acquire a generic DMA engine slave channel */
> -	dma_cap_zero(mask);
> -	dma_cap_set(DMA_SLAVE, mask);
> -
>  	/*
>  	 * If only an RX channel is specified, the driver will
>  	 * attempt to use it bidirectionally, however if it is
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/