linux-kernel - Re: [PATCH V2 2/2] bfin_can: rewrite the driver to support the common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150108091322.GE9157@distanz.ch>
Date:	Thu, 8 Jan 2015 10:13:23 +0100
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	Aaron Wu <Aaron.wu@...log.com>
Cc:	mkl@...gutronix.de, wg@...ndegger.com, linux-can@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	adi-buildroot-devel@...ts.sourceforge.net
Subject: Re: [PATCH V2 2/2] bfin_can: rewrite the driver to support the common

On 2015-01-08 at 07:57:34 +0100, Aaron Wu <Aaron.wu@...log.com> wrote:
> Rewrite the driver to comply to common style with MMU 
> 
> Signed-off-by: Aaron Wu <Aaron.wu@...log.com>
> ---
>  drivers/net/can/bfin_can.c |   21 ++++++++-------------
>  1 file changed, 8 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/can/bfin_can.c b/drivers/net/can/bfin_can.c
> index 0a5eff4..1d116a7 100644
> --- a/drivers/net/can/bfin_can.c
> +++ b/drivers/net/can/bfin_can.c
[...]
> @@ -617,9 +615,6 @@ static int bfin_can_remove(struct platform_device *pdev)
>  
>  	unregister_candev(dev);
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	release_mem_region(res->start, resource_size(res));
> -

struct resource *res will be unused in bfin_can_remove() after this
change, so it should be removed as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/