linux-kernel - Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegsLg2UL06kR=0njvo9Lgdu20BsxxrHw0TyfokLNUg30dg@mail.gmail.com>
Date:	Thu, 8 Jan 2015 14:50:15 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Seunghun Lee <waydi1@...il.com>
Cc:	hujianyang <hujianyang@...wei.com>,
	Sedat Dilek <sedat.dilek@...il.com>,
	richard.weinberger@...il.com,
	Linux-Fsdevel <linux-fsdevel@...r.kernel.org>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-unionfs@...r.kernel.org
Subject: Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

On Wed, Jan 7, 2015 at 4:04 PM, Seunghun Lee <waydi1@...il.com> wrote:
>> On 2015/1/6 22:02, Seunghun Lee wrote:
>>> After patch:
>>> root@...ux86:~# mount -t overlay overlay -olowerdir=lower:lower2 merged
>>> mount: warning: merged seems to be mounted read-only.
>>> root@...ux86:~# mount | grep overlay
>>> overlay on /home/root/merged type overlay (ro,relatime,lowerdir=lower:lower2)
>>> root@...ux86:~# mount -o remount,rw merged
>>> mount: warning: /home/root/merged seems to be mounted read-only.
>>> root@...ux86:~# mount | grep overlay
>>> overlay on /home/root/merged type overlay (ro,relatime,lowerdir=lower:lower2)
>>> root@...ux86:~# echo hi > merged/hi
>>> -sh: merged/hi: Read-only file system
>>> root@...ux86:~#
>>>
>> If users want a rw mount, can we give them a ro mount? I think it's
>> wrong, .remount_fs should refuse this request.

Yeah.  Applied fixed patch.

Thanks,
Mikos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/