linux-kernel - Re: [PATCH] clocksource: tegra: wrap arch/arm-specific sections in CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150108154837.GA1608@ulmo.nvidia.com>
Date:	Thu, 8 Jan 2015 16:48:39 +0100
From:	Thierry Reding <treding@...dia.com>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
CC:	Paul Walmsley <paul@...an.com>, <linux-kernel@...r.kernel.org>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	<linux-tegra@...r.kernel.org>, Allen Martin <amartin@...dia.com>,
	Stephen Warren <swarren@...dia.com>,
	Alexandre Courbot <gnurou@...il.com>
Subject: Re: [PATCH] clocksource: tegra: wrap arch/arm-specific sections in
 CONFIG_ARM

On Thu, Jan 08, 2015 at 03:21:58PM +0100, Daniel Lezcano wrote:
> On 12/09/2014 11:07 PM, Paul Walmsley wrote:
> >
> >Like several of the other files in drivers/clocksource,
> >tegra20_timer.c contains code that can only compile when CONFIG_ARM is
> >enabled.  This causes obvious problems when trying to compile this
> >code for NVIDIA ARM64-based SoCs, such as Tegra132.  The same timer IP
> >blocks exist, so it seems appropriate to provide support for them.
> >
> >So until we figure out a better way to partition this code, wrap the
> >delay_timer and persistent_clock support code with preprocessor tests
> >for CONFIG_ARM.  (The delay_timer code should not be needed at all on
> >ARM64 due to the presence of the ARMv8 architected timer.  The
> >persistent_clock support code could become important once power
> >management modes are implemented that turn off the CPU complex.)
> 
> Well actually putting #ifdef macros in the C code should be avoided if
> possible.
> 
> May be you can replace those macros by:
> 
> if (IS_ENABLED(CONFIG_ARM64)) {
> 	...
> }
> 
> ?

Unfortunately we can't. Some of the symbols in this file are only
defined in headers specific to ARM and not available on ARM64.

Thierry

Content of type "application/pgp-signature" skipped