[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54AEB719.5060103@linaro.org>
Date: Thu, 08 Jan 2015 17:58:01 +0100
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Paul Walmsley <paul@...an.com>, linux-kernel@...r.kernel.org,
Thomas Gleixner <tglx@...utronix.de>
CC: linux-tegra@...r.kernel.org, Allen Martin <amartin@...dia.com>,
Stephen Warren <swarren@...dia.com>,
Thierry Reding <treding@...dia.com>,
Alexandre Courbot <gnurou@...il.com>
Subject: Re: [PATCH] clocksource: tegra: wrap arch/arm-specific sections in
CONFIG_ARM
On 12/09/2014 11:07 PM, Paul Walmsley wrote:
>
> Like several of the other files in drivers/clocksource,
> tegra20_timer.c contains code that can only compile when CONFIG_ARM is
> enabled. This causes obvious problems when trying to compile this
> code for NVIDIA ARM64-based SoCs, such as Tegra132. The same timer IP
> blocks exist, so it seems appropriate to provide support for them.
>
> So until we figure out a better way to partition this code, wrap the
> delay_timer and persistent_clock support code with preprocessor tests
> for CONFIG_ARM.
>
> (The delay_timer code should not be needed at all on
> ARM64 due to the presence of the ARMv8 architected timer. The
> persistent_clock support code could become important once power
> management modes are implemented that turn off the CPU complex.)
IIUC, the cpuidle driver is not yet ready, right ?
If it is the case, this driver is not needed yet, no ?
Perhaps you can rework a bit this driver in the meantime to have a
better fix than disabling the code with macros ?
Otherwise, please try at least to group the code into a minimal set of
macros.
One comment below.
> Signed-off-by: Paul Walmsley <paul@...an.com>
> Signed-off-by: Paul Walmsley <pwalmsley@...dia.com>
> Cc: Allen Martin <amartin@...dia.com>
> Cc: Stephen Warren <swarren@...dia.com>
> Cc: Thierry Reding <treding@...dia.com>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Alexandre Courbot <gnurou@...il.com>
> ---
> Applies against next-20141209.
> Intended for v3.20.
> Boot-tested on Tegra124 Jetson TK1 on next-20141209.
> Also boot-tested on Tegra132 Norrin FFD on next-20141209 + extra,
> unrelated patches.
>
> drivers/clocksource/tegra20_timer.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/clocksource/tegra20_timer.c b/drivers/clocksource/tegra20_timer.c
> index d2616ef16770..83a8f5c9e139 100644
> --- a/drivers/clocksource/tegra20_timer.c
> +++ b/drivers/clocksource/tegra20_timer.c
> @@ -29,8 +29,10 @@
> #include <linux/sched_clock.h>
> #include <linux/delay.h>
>
> +#ifdef CONFIG_ARM
> #include <asm/mach/time.h>
> #include <asm/smp_twd.h>
Is smp_twd.h really needed ?
> +#endif
[ ... ]
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists