[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <D38E8E86660E514AB505863C19C9287C741097AF@ORSMSX102.amr.corp.intel.com>
Date: Fri, 9 Jan 2015 16:41:51 +0000
From: "Ronciak, John" <john.ronciak@...el.com>
To: Ethan Zhao <ethan.zhao@...cle.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
"Allan, Bruce W" <bruce.w.allan@...el.com>,
"Wyborny, Carolyn" <carolyn.wyborny@...el.com>,
"Skidmore, Donald C" <donald.c.skidmore@...el.com>,
"Rose, Gregory V" <gregory.v.rose@...el.com>,
"Vick, Matthew" <matthew.vick@...el.com>,
"Williams, Mitch A" <mitch.a.williams@...el.com>,
"Dev, Vasu" <vasu.dev@...el.com>,
"Parikh, Neerav" <neerav.parikh@...el.com>
CC: Linux NICS <Linux-nics@...tope.jf.intel.com>,
"e1000-devel@...ts.sourceforge.net"
<e1000-devel@...ts.sourceforge.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"ethan.kernel@...il.com" <ethan.kernel@...il.com>,
"brian.maly@...cle.com" <brian.maly@...cle.com>
Subject: RE: [PATCH] i40e: don't enable and init FCOE by default when do PF
reset
Adding Vasu and Neerav
Cheers,
John
> -----Original Message-----
> From: Ethan Zhao [mailto:ethan.zhao@...cle.com]
> Sent: Friday, January 9, 2015 8:38 AM
> To: Kirsher, Jeffrey T; Brandeburg, Jesse; Allan, Bruce W; Wyborny, Carolyn;
> Skidmore, Donald C; Rose, Gregory V; Vick, Matthew; Ronciak, John;
> Williams, Mitch A
> Cc: Linux NICS; e1000-devel@...ts.sourceforge.net; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org; ethan.kernel@...il.com;
> brian.maly@...cle.com; Ethan Zhao
> Subject: [PATCH] i40e: don't enable and init FCOE by default when do PF
> reset
>
> While do PF reset with function i40e_reset_and_rebuild(), it will call
> i40e_init_pf_fcoe() by default if FCOE is defined, thus if the PF is resetted,
> FCOE will be enabled whatever it was - enabled or not.
>
> Such bug might be hit when PF resumes from suspend, run diagnostic test
> with ethtool, setup VLAN etc.
>
> Passed building with v3.19-rc3.
>
> Signed-off-by: Ethan Zhao <ethan.zhao@...cle.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index a5f2660..a2572cc 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -6180,9 +6180,12 @@ static void i40e_reset_and_rebuild(struct i40e_pf
> *pf, bool reinit)
> }
> #endif /* CONFIG_I40E_DCB */
> #ifdef I40E_FCOE
> - ret = i40e_init_pf_fcoe(pf);
> - if (ret)
> - dev_info(&pf->pdev->dev, "init_pf_fcoe failed: %d\n", ret);
> + if (pf->flags & I40E_FLAG_FCOE_ENABLED) {
> + ret = i40e_init_pf_fcoe(pf);
> + if (ret)
> + dev_info(&pf->pdev->dev,
> + "init_pf_fcoe failed: %d\n", ret);
> + }
>
> #endif
> /* do basic switch setup */
> --
> 1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists