linux-kernel - Re: [PATCH 5/5] perf tools: [uclibc] provide stub for pthread_attr_setaffinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 Jan 2015 10:30:54 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Namhyung Kim <namhyung@...nel.org>
CC:	"acme@...hat.com" <acme@...hat.com>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"jolsa@...nel.org" <jolsa@...nel.org>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
	"bp@...e.de" <bp@...e.de>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"Alexey.Brodkin@...opsys.com" <Alexey.Brodkin@...opsys.com>
Subject: Re: [PATCH 5/5] perf tools: [uclibc] provide stub for
 pthread_attr_setaffinity_np

Hi Namhyung,



On Thursday 08 January 2015 01:28 PM, Namhyung Kim wrote:
> On Tue, Jan 06, 2015 at 07:22:15PM +0530, Vineet Gupta wrote:
>> > uClibc Linuxthreads.old doesnt support pthread_attr_setaffinity_np()
>> > call
>> > 
>> > ----------------->8-----------------------
>> >   CC       bench/futex-hash.o
>> >   CC       bench/futex-wake.o
>> > bench/futex-hash.c: In function 'bench_futex_hash':
>> > bench/futex-hash.c:161:3: error: implicit declaration of function
>> > 'pthread_attr_setaffinity_np' [-Werror=implicit-function-declaration]
>> >    ret = pthread_attr_setaffinity_np(&thread_attr, sizeof(cpu_set_t),
>> > &cpu);
>> >    ^
>> > bench/futex-hash.c:161:3: error: nested extern declaration of
>> > 'pthread_attr_setaffinity_np' [-Werror=nested-externs]
>> > ----------------->8-----------------------
>> > 
>> > Signed-off-by: Vineet Gupta <vgupta@...opsys.com>
>> > ---
>> >  tools/perf/bench/futex.h                    | 13 +++++++++++++
>> >  tools/perf/config/Makefile                  |  6 ++++++
>> >  tools/perf/config/feature-checks/Makefile   |  4 ++++
>> >  tools/perf/config/feature-checks/test-all.c |  5 +++++
>> >  4 files changed, 28 insertions(+)
> It seems that you fotgot to add the real test file
> (test-pthread_attr_setaffinity_np.c?) here..

Indeed, apologies for the snafu. I'll include it in v2 for the series.
Any thoughts on rest of patches for the series.
Thanks for the careful review so far.

-Vineet

>
> Thanks,
> Namhyung
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/