linux-kernel - Re: [PATCH 4/5] perf tools: [uclibc] don't rely on glibc malloc working for sz 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150110104458.GC29697@danjae>
Date:	Sat, 10 Jan 2015 19:44:58 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
Cc:	"acme@...hat.com" <acme@...hat.com>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"jolsa@...nel.org" <jolsa@...nel.org>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
	"bp@...e.de" <bp@...e.de>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"Alexey.Brodkin@...opsys.com" <Alexey.Brodkin@...opsys.com>
Subject: Re: [PATCH 4/5] perf tools: [uclibc] don't rely on glibc malloc
 working for sz 0

On Sat, Jan 10, 2015 at 10:16:06AM +0000, Vineet Gupta wrote:
> On Thursday 08 January 2015 01:23 PM, Namhyung Kim wrote:
> > Hmm.. okay.  I think we don't need to allocate the id arrays when size
> > is 0.  So perf_event__process_attr() will have the same problem IMHO.
> > How about this?
> >
> >
> > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> > index 1e90c8557ede..1d826d63bc20 100644
> > --- a/tools/perf/util/evsel.c
> > +++ b/tools/perf/util/evsel.c
> > @@ -797,6 +797,9 @@ int perf_evsel__enable(struct perf_evsel *evsel, int ncpus, int nthreads)
> >  
> >  int perf_evsel__alloc_id(struct perf_evsel *evsel, int ncpus, int nthreads)
> >  {
> > +	if (ncpus == 0 || nthreads == 0)
> > +		return 0;
> > +
> >  	if (evsel->system_wide)
> >  		nthreads = 1;
> 
> Fine by me as I'm not too familiar with perf tools internals.
> So I need to spin a v2 for this or would you rather create a patch with me as
> Reported-by:

Please include this in your v2 and adds me as Suggested-by:

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/