linux-kernel - Re: [PATCH] staging: unisys: Convert direct LOGERR uses to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150111041319.GB22334@kroah.com>
Date:	Sat, 10 Jan 2015 20:13:19 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Benjamin Romer <benjamin.romer@...sys.com>,
	David Kershner <david.kershner@...sys.com>,
	devel@...verdev.osuosl.org, sparmaintainer@...sys.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: unisys: Convert direct LOGERR uses to pr_err

On Sat, Jan 10, 2015 at 07:09:02PM -0800, Joe Perches wrote:
> Use the normal logging facility instead of a new macro.
> 
> Miscellanea:
> 
> o Realign arguments
> o Remove unnecessary alloc error messages as alloc failures
>   already emits a generic OOM message with a dump_stack
> o Add missing newlines to these messages to avoid interleaving
> o Spelling/typo fixes in those messages
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/staging/unisys/include/uisutils.h          |   4 +-
>  drivers/staging/unisys/uislib/uislib.c             | 169 ++++++++++-----------
>  drivers/staging/unisys/uislib/uisqueue.c           |   4 +-
>  drivers/staging/unisys/uislib/uisthread.c          |   4 +-
>  drivers/staging/unisys/uislib/uisutils.c           |  34 ++---
>  drivers/staging/unisys/virthba/virthba.c           | 119 +++++++--------
>  drivers/staging/unisys/virtpci/virtpci.c           |  71 +++++----
>  drivers/staging/unisys/visorchipset/file.c         |   2 +-
>  .../unisys/visorchipset/visorchipset_main.c        | 159 ++++++++++---------
>  9 files changed, 276 insertions(+), 290 deletions(-)
> 
> diff --git a/drivers/staging/unisys/include/uisutils.h b/drivers/staging/unisys/include/uisutils.h
> index 7414220..f937892 100644
> --- a/drivers/staging/unisys/include/uisutils.h
> +++ b/drivers/staging/unisys/include/uisutils.h
> @@ -206,10 +206,10 @@ wait_for_valid_guid(uuid_le __iomem *guid)
>  			      (void __iomem *)guid, sizeof(uuid_le));
>  		if (uuid_le_cmp(tmpguid, NULL_UUID_LE) != 0)
>  			break;
> -		LOGERR("Waiting for non-0 GUID (why???)...\n");
> +		pr_err("Waiting for non-0 GUID (why???)...\n");

I rejected the other patch that did much this same thing, almost all of
these should be converted to use dev_* calls instead of pr_* calls, as
this is a driver, and drivers should always have access to a struct
device.  If not, they need to be fixed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/