| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1420952121.32288.1.camel@perches.com> Date: Sat, 10 Jan 2015 20:55:21 -0800 From: Joe Perches <joe@...ches.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Benjamin Romer <benjamin.romer@...sys.com>, David Kershner <david.kershner@...sys.com>, devel@...verdev.osuosl.org, sparmaintainer@...sys.com, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] staging: unisys: Convert direct LOGERR uses to pr_err On Sat, 2015-01-10 at 20:13 -0800, Greg Kroah-Hartman wrote: > On Sat, Jan 10, 2015 at 07:09:02PM -0800, Joe Perches wrote: > > Use the normal logging facility instead of a new macro. > > > > Miscellanea: > > > > o Realign arguments > > o Remove unnecessary alloc error messages as alloc failures > > already emits a generic OOM message with a dump_stack > > o Add missing newlines to these messages to avoid interleaving > > o Spelling/typo fixes in those messages [] > I rejected the other patch that did much this same thing, almost all of > these should be converted to use dev_* calls instead of pr_* calls, as > this is a driver, and drivers should always have access to a struct > device. If not, they need to be fixed. Baby steps. This one prevents interleaving and fixes typos. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists