lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 12 Jan 2015 11:31:35 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Bjorn Andersson <bjorn@...o.se>, Tim Kryger <tim.kryger@...il.com>
Cc:	Alexandre Courbot <acourbot@...dia.com>,
	Sachin Kamat <spk.linux@...il.com>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>,
	linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: Possible regression with commit 52221610d

On 5 January 2015 at 20:52, Bjorn Andersson <bjorn@...o.se> wrote:
> On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger <tim.kryger@...il.com> wrote:
>> On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson <bjorn@...o.se> wrote:
> [..]
>>> Non-the-less, feel free to propose a patch and I will give it a test.
>>
>> Lets start with the simplest change first.  Please give this a try and
>> let me know what you think.
>>
>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
>> index ada1a3e..59a328a 100644
>> --- a/drivers/mmc/host/sdhci.c
>> +++ b/drivers/mmc/host/sdhci.c
>> @@ -1239,6 +1239,12 @@ static void sdhci_set_power(struct sdhci_host
>> *host, unsigned char mode,
>>                 spin_unlock_irq(&host->lock);
>>                 mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd);
>>                 spin_lock_irq(&host->lock);
>> +
>> +               if (mode != MMC_POWER_OFF)
>> +                       sdhci_writeb(host, SDHCI_POWER_ON, SDHCI_POWER_CONTROL);
>> +               else
>> +                       sdhci_writeb(host, 0, SDHCI_POWER_CONTROL);
>> +
>>                 return;
>>         }
>>
>>
>> Thanks again for your help in getting to the bottom of this.
>
> Sorry for the delay, but
>
> Tested-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>
>

This looks an okay approach. Please send a proper patch for me to
apply as a fix.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists