linux-kernel - Re: [RFC] hwmon: jc42: use bitops' sign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150112195317.GB18549@roeck-us.net>
Date:	Mon, 12 Jan 2015 11:53:17 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Martin Kepplinger <martink@...teo.de>
Cc:	mingo@...nel.org, peterz@...radead.org, paulmck@...ux.vnet.ibm.com,
	tytso@....edu, maxime.coquelin@...com, linux-kernel@...r.kernel.org
Subject: Re: [RFC] hwmon: jc42: use bitops' sign_extend16

On Mon, Jan 12, 2015 at 06:28:20PM +0100, Martin Kepplinger wrote:
> Example change, using new sign_extend functions.

No need to drop the Signed-off: line; it only means that I can not take
the patch even if I want to. Also, if the patch itself is final, no need
to state that it is an example in the description. Instead, use an
introductory mail (RFC PATCH 0/x] to explain the background.

Otherwise looks good; feel free to add

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

to the next version.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/