linux-kernel - Re: [PATCH] mmc: sdhci: Set SDHCI_POWER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Jan 2015 09:53:33 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Tim Kryger <tim.kryger@...il.com>
Cc:	Chris Ball <chris@...ntf.net>,
	Alexandre Courbot <gnurou@...il.com>,
	Sachin Kamat <spk.linux@...il.com>,
	Linux MMC List <linux-kernel@...r.kernel.org>,
	linux-mmc <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH] mmc: sdhci: Set SDHCI_POWER_ON with external vmmc

+ linux-mmc

On 14 January 2015 at 07:24, Tim Kryger <tim.kryger@...il.com> wrote:
> Host controllers lacking the required internal vmmc regulator may still
> follow the spec with regard to the LSB of SDHCI_POWER_CONTROL.  Set the
> SDHCI_POWER_ON bit when vmmc is enabled to encourage the controller to
> to drive CMD, DAT, SDCLK.
>
> This fixes a regression observed on some Qualcomm and Nvidia boards
> caused by 5222161 mmc: sdhci: Improve external VDD regulator support.
>
> Signed-off-by: Tim Kryger <tim.kryger@...il.com>
> Tested-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>

Thanks! Applied for fixes.

I noticed this wasn't posted to linux-mmc. I am anyway picking it up
as this change has already been discussed and tested, see:
https://lkml.org/lkml/2014/11/3/1029

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index ada1a3e..59a328a 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1239,6 +1239,12 @@ static void sdhci_set_power(struct sdhci_host *host, unsigned char mode,
>                 spin_unlock_irq(&host->lock);
>                 mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd);
>                 spin_lock_irq(&host->lock);
> +
> +               if (mode != MMC_POWER_OFF)
> +                       sdhci_writeb(host, SDHCI_POWER_ON, SDHCI_POWER_CONTROL);
> +               else
> +                       sdhci_writeb(host, 0, SDHCI_POWER_CONTROL);
> +
>                 return;
>         }
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/