linux-kernel - Re: [PATCH] sound/oss: use current->state helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Jan 2015 08:33:26 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Davidlohr Bueso <dave@...olabs.net>
Cc:	Andrew Veliath <andrewtv@....net>,
	Jaroslav Kysela <perex@...ex.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound/oss: use current->state helpers

At Wed, 14 Jan 2015 23:11:43 -0800,
Davidlohr Bueso wrote:
> 
> From: Davidlohr Bueso <dave@...olabs.net>
> 
> Call __set_current_state() instead of assigning the new state directly.
> These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments, keeping
> track of who changed the state.
> 
> Signed-off-by: Davidlohr Bueso <dbueso@...e.de>

The author and sign-off have different addresses.  Could you align?


thanks,

Takashi


> ---
>  sound/oss/msnd_pinnacle.c | 4 ++--
>  sound/oss/swarm_cs4297a.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/oss/msnd_pinnacle.c b/sound/oss/msnd_pinnacle.c
> index c23f9f9..a8ceef8 100644
> --- a/sound/oss/msnd_pinnacle.c
> +++ b/sound/oss/msnd_pinnacle.c
> @@ -675,7 +675,7 @@ static void dsp_write_flush(void)
>  		timeout);
>  	clear_bit(F_WRITEFLUSH, &dev.flags);
>  	if (!signal_pending(current)) {
> -		current->state = TASK_INTERRUPTIBLE;
> +		__set_current_state(TASK_INTERRUPTIBLE);
>  		schedule_timeout(get_play_delay_jiffies(DAP_BUFF_SIZE));
>  	}
>  	clear_bit(F_WRITING, &dev.flags);
> @@ -1288,7 +1288,7 @@ static int __init calibrate_adc(WORD srate)
>  		       & ~0x0001, dev.SMA + SMA_wCurrHostStatusFlags);
>  	if (msnd_send_word(&dev, 0, 0, HDEXAR_CAL_A_TO_D) == 0 &&
>  	    chk_send_dsp_cmd(&dev, HDEX_AUX_REQ) == 0) {
> -		current->state = TASK_INTERRUPTIBLE;
> +		__set_current_state(TASK_INTERRUPTIBLE);
>  		schedule_timeout(HZ / 3);
>  		return 0;
>  	}
> diff --git a/sound/oss/swarm_cs4297a.c b/sound/oss/swarm_cs4297a.c
> index a33e8ce..213a416 100644
> --- a/sound/oss/swarm_cs4297a.c
> +++ b/sound/oss/swarm_cs4297a.c
> @@ -1654,7 +1654,7 @@ static int drain_dac(struct cs4297a_state *s, int nonblock)
>          s->dma_dac.hwptr = s->dma_dac.swptr = hwptr;
>          spin_unlock_irqrestore(&s->lock, flags);
>  	remove_wait_queue(&s->dma_dac.wait, &wait);
> -	current->state = TASK_RUNNING;
> +	__set_current_state(TASK_RUNNING);
>  	return 0;
>  }
>  
> -- 
> 2.1.2
> 
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/