linux-kernel - Re: [3/5, media] pwc-if: fix build warning when !CONFIG_USB_PWC_INPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54B79900.50705@redhat.com>
Date:	Thu, 15 Jan 2015 11:40:00 +0100
From:	Hans de Goede <hdegoede@...hat.com>
To:	Luis Henriques <luis.henriques@...onical.com>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>
CC:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [3/5, media] pwc-if: fix build warning when !CONFIG_USB_PWC_INPUT_EVDEV

Hi,

On 02-10-14 01:10, Luis Henriques wrote:
> Label err_video_unreg in function usb_pwc_probe() is only used when
> CONFIG_USB_PWC_INPUT_EVDEV is defined.
>
> drivers/media/usb/pwc/pwc-if.c:1104:1: warning: label 'err_video_unreg' defined but not used [-Wunused-label]
>
> Signed-off-by: Luis Henriques <luis.henriques@...onical.com>

Sorry for the slow reaction, I somehow missed this patch and just found it in my
patchwork TODO.

I understand what you're trying to achieve here, but NAK to the implementation,
this is breaking the code flow wrt error handling, making it much harder
to double check that everything is being cleaned up properly.

Regards,

Hans


>
> ---
> drivers/media/usb/pwc/pwc-if.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c
> index 15b754da4a2c..e6b7e63b0b8e 100644
> --- a/drivers/media/usb/pwc/pwc-if.c
> +++ b/drivers/media/usb/pwc/pwc-if.c
> @@ -1078,7 +1078,8 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id
>   	pdev->button_dev = input_allocate_device();
>   	if (!pdev->button_dev) {
>   		rc = -ENOMEM;
> -		goto err_video_unreg;
> +		video_unregister_device(&pdev->vdev);
> +		goto err_unregister_v4l2_dev;
>   	}
>
>   	usb_make_path(udev, pdev->button_phys, sizeof(pdev->button_phys));
> @@ -1095,14 +1096,13 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id
>   	if (rc) {
>   		input_free_device(pdev->button_dev);
>   		pdev->button_dev = NULL;
> -		goto err_video_unreg;
> +		video_unregister_device(&pdev->vdev);
> +		goto err_unregister_v4l2_dev;
>   	}
>   #endif
>
>   	return 0;
>
> -err_video_unreg:
> -	video_unregister_device(&pdev->vdev);
>   err_unregister_v4l2_dev:
>   	v4l2_device_unregister(&pdev->v4l2_dev);
>   err_free_controls:
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/