linux-kernel - Re: [Bugfix v4 0/2] Fix xen IRQ allocation failure caused by commit b81975eade8c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54B7D08E.7060904@linux.intel.com>
Date:	Thu, 15 Jan 2015 22:37:02 +0800
From:	Jiang Liu <jiang.liu@...ux.intel.com>
To:	Sander Eikelenboom <linux@...elenboom.it>
CC:	David Vrabel <david.vrabel@...rix.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
	Tony Luck <tony.luck@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [Bugfix v4 0/2] Fix xen IRQ allocation failure caused by commit
 b81975eade8c

On 2015/1/15 22:22, Sander Eikelenboom wrote:
> 
> Thursday, January 15, 2015, 2:04:34 PM, you wrote:
> 
>> With more knowledge of Xen interrupt manangement subsytem, I realized
>> previous three versions to fix https://lkml.org/lkml/2014/12/19/178 are
>> just plainly wrong. Those patches try to fix the issue by creating
>> irqdomain for IOAPICs for PV domains, which effectively let native
>> IOAPIC driver and Xen PV interrupt management subsystem to manage
>> IOAPIC irqs concurrently, sounds unpredictable.
> 
>> Sorry for those wrong fixes. The good news is that the new fix does
>> make code simpler and easier to maintain.
> 
>> I have tested the patchset on Intel platform with bare metal and Dom0
>> kernels.
> 
>> Hi Sander,
>>         Could you please help to test it again?
> 
>> Regards!
>> Gerry
> 
> Hi Gerry,
> 
> These patches fix the first symptom of the powerbutton not working.
> 
> Unfortunately it doesn't fix the second symptoms with pci-passthrough,
> the device still doesn't receive irq's on intel and the video device still haas
> issues on AMD.
> 
> What i have tested extensively and works stable for me is:
> david's patch + revert of cffe0a2b5a34c95a4dadc9ec7132690a5b0f6687 "x86, irq: Keep balance of IOAPIC pin reference count" 
> 
> Hope that helps in finding the solution.
Hi Sander,
	Yes, this is only a fix for power button(ACPI SCI allocation).
I'm still reading xen-pciback code to figure out the possible cause
and fix for the second issue.
Thanks!
Gerry.

> 
> --
> Sander
> 
> 
>> Jiang Liu (2):
>>   xen/pci: Kill function xen_setup_acpi_sci()
>>   xen/pci: Simplify x86/pci/xen.c by killing gsi_override related code
> 
>>  arch/x86/kernel/acpi/boot.c |   26 ++++++++---------
>>  arch/x86/pci/xen.c          |   68 ++++---------------------------------------
>>  2 files changed, 19 insertions(+), 75 deletions(-)
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/