linux-kernel - Re: [PATCH] Makefile: allow building selected tests with non-NPTL toolchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150115124557.5d2d34ad@sluggy>
Date:	Thu, 15 Jan 2015 12:45:57 -0600
From:	Clark Williams <clark.williams@...il.com>
To:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Cc:	"jkacur@...hat.com" <jkacur@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-rt-users@...r.kernel.org" <linux-rt-users@...r.kernel.org>,
	"Vineet Gupta" <Vineet.Gupta1@...opsys.com>
Subject: Re: [PATCH] Makefile: allow building selected tests with non-NPTL
 toolchain

On Thu, 15 Jan 2015 07:35:01 +0000
Alexey Brodkin <Alexey.Brodkin@...opsys.com> wrote:

> Hi Clark, John,
> 
> On Mon, 2014-11-10 at 10:16 +0300, Alexey Brodkin wrote:
> > Some architectures are still stuck with non-NPTL toolchains.
> > These are for example ARC, Blackfin, Xtensa etc.
> > 
> > Still rt-tests are very good benchmarks and it would be good to enable use of
> > at least selected (those that will be built) tests on those architectures.
> > 
> > This change makes it possible to only build subset of tests that don't require
> > NPTL calls.
> > 
> > By default behavior is not modified - all tests are built, but if one wants
> > to build with non-NPTL toolchain just add "HAVE_NPTL=no" in command line
> > or modify "HAVE_NPTL" variable right in Makefile and execute "make".
> > 
> > Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com>
> > Cc: Vineet Gupta <vgupta@...opsys.com>
> > Cc: Clark Williams <clark.williams@...il.com>
> > ---
> >  Makefile | 11 ++++++++---
> >  1 file changed, 8 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index 318a5c6..675edf7 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1,8 +1,13 @@
> >  VERSION_STRING = 0.89
> >  
> > -sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c	\
> > -	  ptsematest.c sigwaittest.c svsematest.c pmqtest.c sendme.c 	\
> > -	  pip_stress.c hackbench.c
> > +HAVE_NPTL ?= yes
> > +
> > +ifeq ($(HAVE_NPTL),yes)
> > +sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c
> > +endif
> > +
> > +sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \
> > +	  hackbench.c
> >  
> >  TARGETS = $(sources:.c=)
> 
> I'm wondering if there's a chance to get this patch reviewed and if
> there're no objections applied?
> 
> Regards,
> Alexey

Changes looked good to me. I've pulled it in and it will be in the next
release.

Clark

Content of type "application/pgp-signature" skipped