linux-kernel - Re: [PATCH 2/2] tty: serial: 8250_core: Check that port->line is >=0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54B8ED20.60308@linutronix.de>
Date:	Fri, 16 Jan 2015 11:51:12 +0100
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Michal Simek <michal.simek@...inx.com>,
	linux-kernel@...r.kernel.org, monstr@...str.eu
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-serial@...r.kernel.org, Jiri Slaby <jslaby@...e.cz>,
	Peter Hurley <peter@...leysoftware.com>,
	Alan Cox <alan@...ux.intel.com>,
	Tony Lindgren <tony@...mide.com>,
	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 2/2] tty: serial: 8250_core: Check that port->line is
 >=0

- Yoshihiro YUNOMAE
(reason: 550 5.1.1 <yoshihiro.yunomae.ez@...achi.com>: Recipient
address rejected: User Unknown)

On 01/16/2015 11:37 AM, Michal Simek wrote:
> Hi,

Hi,

> Origin patch looks good to me but this checking will be good to add.
> Are you using of_serial.c because I didn't find any of_alias_get_id call
> for 8250?

I'm using of_alias_get_id() in 8250_omap.c which made it into
v3.19-rc1. I think the change you mention made it one release earlier.

> Your logic here is a little bit different than I have in my tree.
> (Some sort of pl011 solution). You don't need to failed if you port.line is
> below 0 but if you are not able to read aliases port enumeration
> may be unpredictable.

For omap we should have valid aliases because we have multiple UARTs.
So the platform id should always be >=0 and the DT includes it already.
And Tony wanted to have predicted numbers so I don't mind to fail here.
Also it is nice if you have ttyS2 which maps UART2 in the manual even
without having ttyS[01].

> Thanks,
> Michal

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/