linux-kernel - Re: [PATCH 2/2] tty: serial: 8250_core: Check that port->line is >=0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ecb2012312c4af5bbd395391aa82921@BY2FFO11FD005.protection.gbl>
Date:	Fri, 16 Jan 2015 12:02:02 +0100
From:	Michal Simek <michal.simek@...inx.com>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Michal Simek <michal.simek@...inx.com>,
	<linux-kernel@...r.kernel.org>, <monstr@...str.eu>,
	Olof Johansson <olof@...om.net>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-serial@...r.kernel.org>, Jiri Slaby <jslaby@...e.cz>,
	Peter Hurley <peter@...leysoftware.com>,
	Alan Cox <alan@...ux.intel.com>,
	Tony Lindgren <tony@...mide.com>,
	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 2/2] tty: serial: 8250_core: Check that port->line is
 >=0

On 01/16/2015 11:51 AM, Sebastian Andrzej Siewior wrote:
> - Yoshihiro YUNOMAE
> (reason: 550 5.1.1 <yoshihiro.yunomae.ez@...achi.com>: Recipient
> address rejected: User Unknown)
> 
> On 01/16/2015 11:37 AM, Michal Simek wrote:
>> Hi,
> 
> Hi,
> 
>> Origin patch looks good to me but this checking will be good to add.
>> Are you using of_serial.c because I didn't find any of_alias_get_id call
>> for 8250?
> 
> I'm using of_alias_get_id() in 8250_omap.c which made it into
> v3.19-rc1. I think the change you mention made it one release earlier.

I see
serial: of-serial: fetch line number from DT
commit 1bd8324535ec1ff44aef55c0e40b9e7d56b310fb

but it was reverted

Revert "serial: of-serial: fetch line number from DT"
commit e4c787dac21e50ac9ef53fac91b9182d4fede465

Olof: what was the reason for that breakage?
Is it missing alias list on Tegra?
which caused that port->line number is bogus.

Thanks,
Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/