linux-kernel - Re: [PATCH] Staging: slicoss: Fix long line issues in slicoss.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150118001331.GA32461@kroah.com>
Date:	Sat, 17 Jan 2015 16:13:31 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sean Cleator <seancleator@...mail.co.uk>
Cc:	David Matlack <matlackdavid@...il.com>, devel@...verdev.osuosl.org,
	Vincent Heuken <me@...centheuken.com>,
	linux-kernel@...r.kernel.org, Lior Dotan <liodot@...il.com>,
	Christopher Harrer <charrer@...critech.com>,
	Monam Agarwal <monamagarwal123@...il.com>,
	Joe Perches <joe@...ches.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH] Staging: slicoss: Fix long line issues in slicoss.c

On Wed, Dec 03, 2014 at 01:53:18PM +0000, Sean Cleator wrote:
> A patch to the slicoss.c file to fix some of the long line issues found by the
> checkpath.pl tool
>  
> Signed-off-by: Sean Cleator <seancleator@...mail.co.uk>
> 
> ---
>  drivers/staging/slicoss/slicoss.c | 39 ++++++++++++++++++++++++++-------------
>  1 file changed, 26 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 56ca3b6..4df4a7e 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -498,12 +498,14 @@ static int slic_card_download(struct adapter *adapter)
>  			slic_reg32_write(&slic_regs->slic_wcs,
>  					 baseaddress + codeaddr, FLUSH);
>  			/* Write out instruction to low addr */
> -			slic_reg32_write(&slic_regs->slic_wcs, instruction, FLUSH);
> +			slic_reg32_write(&slic_regs->slic_wcs,
> +					instruction, FLUSH);
>  			instruction = *(u32 *)(fw->data + index);
>  			index += 4;
>  
>  			/* Write out instruction to high addr */
> -			slic_reg32_write(&slic_regs->slic_wcs, instruction, FLUSH);
> +			slic_reg32_write(&slic_regs->slic_wcs,
> +					instruction, FLUSH);
>  			instruction = *(u32 *)(fw->data + index);
>  			index += 4;
>  		}
> @@ -1533,14 +1535,18 @@ retry_rcvqfill:
>  				dev_err(dev, "%s: LOW 32bits PHYSICAL ADDRESS == 0\n",
>  					__func__);
>  				dev_err(dev, "skb[%p] PROBLEM\n", skb);
> -				dev_err(dev, "         skbdata[%p]\n", skb->data);
> +				dev_err(dev, "         skbdata[%p]\n",
> +						skb->data);
>  				dev_err(dev, "         skblen[%x]\n", skb->len);
>  				dev_err(dev, "         paddr[%p]\n", paddr);
>  				dev_err(dev, "         paddrl[%x]\n", paddrl);
>  				dev_err(dev, "         paddrh[%x]\n", paddrh);
> -				dev_err(dev, "         rcvq->head[%p]\n", rcvq->head);
> -				dev_err(dev, "         rcvq->tail[%p]\n", rcvq->tail);
> -				dev_err(dev, "         rcvq->count[%x]\n", rcvq->count);
> +				dev_err(dev, "         rcvq->head[%p]\n",
> +						rcvq->head);
> +				dev_err(dev, "         rcvq->tail[%p]\n",
> +						rcvq->tail);
> +				dev_err(dev, "         rcvq->count[%x]\n",
> +						rcvq->count);
>  				dev_err(dev, "SKIP THIS SKB!!!!!!!!\n");
>  				goto retry_rcvqfill;
>  			}


This change makes the code look worse, don't you think?  Please don't do
that.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/